Skip to content

Backport CMS features - #67

Closed
Hackwar wants to merge 1 commit into
joomla-framework:4.x-devfrom
Hackwar:cms
Closed

Hackwar wants to merge 1 commit into
joomla-framework:4.x-devfrom
Hackwar:cms

Conversation

@Hackwar

@Hackwar Hackwar commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

What the title says.

@SniperSister

Copy link
Copy Markdown
Contributor

@Hackwar compared with CMS http package, looks good to me

@HLeithner HLeithner left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks ok to me

Comment thread src/Transport/Curl.php
Comment on lines +352 to +359
$curlVersion = curl_version();

// If open_basedir is enabled we also need to check if libcurl version is 7.19.4 or higher
if (!\ini_get('open_basedir') || version_compare($curlVersion['version'], '7.19.4', '>=')) {
return true;
}

return false;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this, that version is from 2009 and I hope nobody is using this version or earlier anymore.

@SniperSister

Copy link
Copy Markdown
Contributor

see #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants